Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider analysis feedback for enabled conflicting rules #58088

Closed
pq opened this issue Dec 16, 2019 · 4 comments
Closed

consider analysis feedback for enabled conflicting rules #58088

pq opened this issue Dec 16, 2019 · 4 comments
Assignees
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Dec 16, 2019

See #58087 for an example (unnecessary_finals vs. prefer_final_locals).

/fyi @bwilkerson

@pq pq added the type-enhancement A request for a change that isn't a bug label Dec 16, 2019
@pq
Copy link
Member Author

pq commented Dec 16, 2019

(Note to self: we might consider capturing, and at least documenting, these correspondences when we do "the big NNBD audit".)

Implementation bike-shed.

@incompatibleWith('unnecessary_finals')
class PreferFinalLocals extends LintRule implements NodeLintRule {
  ...
}

@bwilkerson
Copy link
Member

I think that would be a good addition.

@pq
Copy link
Member Author

pq commented Jan 15, 2020

Update: LintRules now allow for specifying incompatibleRules which is enforced by DAS.

Next up:

@pq
Copy link
Member Author

pq commented Jan 15, 2020

Closing in favor of specific follow-on issues (#1964 and #58112).

@pq pq closed this as completed Jan 15, 2020
@devoncarew devoncarew added analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-lang/linter Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants