omit_local_variable_types false positive

[davidmorgan]

It looks like the lint considers Foo<dynamic> and Foo<Object> to be the same, so it doesn't allow a left hand side type to 'cast' between the two:

class A<T> {
  T _value;
  A(this._value);
 
  T get value => _value;
}

class Foo {
  String foo;
 
  Foo(this.foo);
}

A<Object> b() {
  return A<Foo>(Foo('hello world'));
}

void main() async {
  // This gives #omit_local_variable_types
  // final A a = b();
  // This gives The getter 'foo' isn't defined for the class 'Object'.
  final a = b();
  final s = a.value.foo;
  print(s);
}

[srawlins]

I believe this is a duplicate of #58201, which has lots of discussion.

[davidmorgan]

@srawlins I don't think it's a duplicate:

• This issue is about a problem with the lint; it treats dynamic and Object as the same, so it gives a false positive
• Suggested code from omit_local_variable_types linter fails at runtime #58201 is about a problem with the quick fix, it removes type information from the LHS without putting it back on the RHS
  Thanks.

[srawlins]

Good catch.