Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: @override and @deprecated ignored on properties #8931

Closed
kevmoo opened this issue Mar 5, 2013 · 13 comments
Closed

editor: @override and @deprecated ignored on properties #8931

kevmoo opened this issue Mar 5, 2013 · 13 comments
Assignees
Labels
analyzer-warning Issues with the analyzer's Warning codes closed-obsolete Closed as the reported issue is no longer relevant
Milestone

Comments

@kevmoo
Copy link
Member

kevmoo commented Mar 5, 2013

What steps will reproduce the problem?

@deprecated
LoggerEvents get on => LoggerEvents(this);

@OverRide
bool get propNotOnSuperClass => null;

What is the expected output? What do you see instead?

Expect to see line through 'on' member and uses flagged.
Expect to see warning about @­override on a member not on super class.

Instead: bupkis

Behavior is as expected on methods.

What version of the product are you using? On what operating system?

Dart VM version: 0.4.1.0 r19425 (Mon Mar 4 22:47:26 2013)

@sethladd
Copy link
Contributor

sethladd commented Mar 6, 2013

Added Area-Editor, Triaged labels.

@clayberg
Copy link

Set owner to @stevemessick.
Added this to the Later milestone.
Removed Type-Defect label.
Added Type-Enhancement label.

@stevemessick
Copy link
Contributor

Set owner to @scheglov.

@scheglov
Copy link
Contributor

Marked this as being blocked by #10161.

@scheglov
Copy link
Contributor

@kevmoo
Copy link
Member Author

kevmoo commented May 6, 2014

I just hit this again with a static property: deprecated warnings are not showing up at usage sites or at the definition

Also, changing this back to be a defect. We have inconsistent behavior between member types.


Removed this from the Later milestone.
Removed Type-Enhancement label.
Added Type-Defect label.

@bwilkerson
Copy link
Member

Added this to the 1.5 milestone.
Added Analyzer-Hint label.

@scheglov
Copy link
Contributor

scheglov commented May 8, 2014

Please provide a test works.
Works for me, see screenshot.


Attachment:
[Screen Shot 2014-05-08 at 8.42.43 AM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-8931/comment-8/Screen Shot 2014-05-08 at 8.42.43 AM.png) (154.85 KB)


Added NeedsInfo label.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@sethladd
Copy link
Contributor

Added AssumedStale label.

@clayberg
Copy link

Added this to the 1.6 milestone.

@kevmoo kevmoo added Type-Defect analyzer-warning Issues with the analyzer's Warning codes closed-obsolete Closed as the reported issue is no longer relevant labels Aug 23, 2014
@kevmoo kevmoo added this to the 1.6 milestone Aug 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-warning Issues with the analyzer's Warning codes closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

7 participants