Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DartPad embed injector #229

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Update DartPad embed injector #229

merged 2 commits into from
Oct 16, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Oct 9, 2024

  • Update to web ^1.1.0
  • Use the new cross origin window support from package:web
  • Support overriding the host authority with an embed argument
  • Use Uri support for building iframe URL rather than doing so manually

johnpryan
johnpryan approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@parlough parlough merged commit 7527a0e into main Oct 16, 2024
8 checks passed
@parlough parlough deleted the feat/updated-dartpad-injector branch October 16, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpryan johnpryan johnpryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parlough @johnpryan