From 694ab1a97e71234d000a279521389c715eb8f435 Mon Sep 17 00:00:00 2001 From: Jon Tippens Date: Wed, 7 Aug 2019 09:52:38 -0700 Subject: [PATCH] async await codelab (#1659) * Add WIP async await codelab * Limit lines to 80 chars * Round 1 of revisions: - add futures codelab to sidenav - add futures codelab to /codelabs page - update 'url' global to dart.dev - move futures codelab to /codelabs/async-await (formerly incorrectly placed in /language) - sundry content corrections in futures codelab * Add more updates per language comments/suggestions review feedback * Further small updates addressing review comments. * Configure site.alert templates and update futures codelab w/ templates * Add "Practicing" section iframe; slight restructure for "Errors" section * Added dartpad examples * Remove extra title * Remove section head and use of "future object" * Remove typos * Punctuate all bulleted list items. * Allow check-code to fail for dart dev builds * Correct mistaken exclusion of check-code from builds * Allow failure for check-code.sh * Allow failure for both check-code and analyze-and-test-examples * Updates per ux and tw review * More updates per review from @sfshaza2 * Updates per latest sfshaza2 comments * Incorporate first part of changes from UX round 2 * Correct typos, turn on latest DartPad UI, and misc small fxies * Update descriptions for examples * Add updates from observing test user * Minor update for example missing a border, extra sentence for DartPad * Re-organize introduction per latest feedback: - Remove heading for introduction - Remove DartPad example - Eliminate "key terms" section - Distribute key terms definitions across relevant portions codelab * Remove "!" characters from "Putting it all together" section * Adding changes from latest review * Refactored sync / async comparison section into 2 columns * Updated instructions before each example * Add changes before switching markup back to single-column view * Completed markup re-write * Finished updates from latest review comments * End with new lines for .travis.yml and .firebaserc * Remove dartpad includes file, update nav per review comments * Update codelab title * Incorporate suggestions from latest review * Enforce 80 char line limit * Small changes from latest review * Updates from latest review * Test omitting refresh-code-excerpts.sh - failing built * Remove test fix for build * Some changes based on recent review * Incorporate latest review items * Remove 'before running it' * Exercise applies to "Working with futures" * More updates - latest review * Add survey at the end of the codelab --- .gitignore | 1 + _config.yml | 24 ++ src/_data/side-nav.yml | 6 +- src/codelabs/async-await/index.md | 497 ++++++++++++++++++++++++++++++ src/codelabs/index.md | 7 +- 5 files changed, 531 insertions(+), 4 deletions(-) create mode 100644 src/codelabs/async-await/index.md diff --git a/.gitignore b/.gitignore index e4ef18d4d1..c423abd931 100644 --- a/.gitignore +++ b/.gitignore @@ -10,6 +10,7 @@ .pub .*-cache/ .vscode +.spelling _asset_bundler_cache _bookhtml _cache/ diff --git a/_config.yml b/_config.yml index 9fec06cb16..81ffdb8332 100644 --- a/_config.yml +++ b/_config.yml @@ -92,6 +92,30 @@ assets: future: true # In support of https://github.com/dart-lang/site-www/issues/1111 +## Site-wide shorthands + +os-list: [Windows, macOS, Linux] + +alert: + important: >- +