Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev the dep on package:glob and publish new versions #1784

Closed
devoncarew opened this issue Nov 7, 2022 · 6 comments
Closed

rev the dep on package:glob and publish new versions #1784

devoncarew opened this issue Nov 7, 2022 · 6 comments

Comments

@devoncarew
Copy link
Member

This is a tracking issue for:

  • reving the package:test_core dep on package:glob to 2.1.1 (not yet published version)
  • publish new versions of the test package(s) with this change

That will help mitigate breakages that users see from dart-lang/sdk#49647 (older versions of package:file running on newer - Dart 2.19.0-dev and later - SDKs).

@jakemac53
Copy link
Contributor

I don't believe this is worthwhile - package upgrading is all or nothing anyways so people will get the latest glob when they update to a version of package:test that would give them the new constraint anyways

@jakemac53
Copy link
Contributor

And if they can't for some reason get the latest glob, they would just get an older version of package test selected which we wouldn't want

@devoncarew
Copy link
Member Author

I don't believe this is worthwhile - package upgrading is all or nothing anyways so people will get the latest glob when they update to a version of package:test that would give them the new constraint anyways

That's true if they run dart pub upgrade but not true for dart pub get.

And if they can't for some reason get the latest glob

The deps for glob (and file) haven't otherwised changed so there shouldn't be any issues resolving it.

@jakemac53
Copy link
Contributor

That's true if they run dart pub upgrade but not true for dart pub get.

It is true for dart pub get as well. Users will be on the same (old) version of package:test if they do that. Or, if its a new clone they will get the latest version of test + glob. Or if they check in their pubspec.lock it will give them the old test & glob.

@jakemac53
Copy link
Contributor

The deps for glob (and file) haven't otherwised changed so there shouldn't be any issues resolving it.

It would be rare I agree but if some other package had an upper bound constraint on glob that was weirdly tight, then it could happen.

@natebosch
Copy link
Member

Closing since I don't think that bumping this dependency is going to have a meaningful impact on user experience - the set of users who happen to manually change their test dependency before a pub get is likely to be small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants