issues with DDC's strong mode

[devoncarew]

The getter 'name' is not defined for the class 'Token' (lib/src/parser.dart, line 257, col 47)
The getter 'name' is not defined for the class 'Token' (lib/src/parser.dart, line 264, col 22)
The method 'expand' is not defined for the class 'SourceSpan' (lib/src/parser.dart, line 265, col 19)
The method 'expand' is not defined for the class 'SourceSpan' (lib/src/parser.dart, line 271, col 19)
The method 'expand' is not defined for the class 'SourceSpan' (lib/src/parser.dart, line 300, col 16)
The getter 'style' is not defined for the class 'Token' (lib/src/parser.dart, line 306, col 32)
The method 'expand' is not defined for the class 'SourceSpan' (lib/src/parser.dart, line 311, col 16)
The getter 'value' is not defined for the class 'Token' (lib/src/parser.dart, line 311, col 42)
The getter 'style' is not defined for the class 'Token' (lib/src/parser.dart, line 311, col 55)
The method 'expand' is not defined for the class 'SourceSpan' (lib/src/parser.dart, line 318, col 16)
The method 'expand' is not defined for the class 'SourceSpan' (lib/src/parser.dart, line 325, col 16)
The method 'expand' is not defined for the class 'SourceSpan' (lib/src/parser.dart, line 332, col 16)
The method 'expand' is not defined for the class 'SourceSpan' (lib/src/parser.dart, line 340, col 16)
The getter 'style' is not defined for the class 'Token' (lib/src/scanner.dart, line 446, col 56)

@nex3, @jmesserly, I believe these issues are all related. I'm not sure if they're real issues or if DDC's type promotion needs to be improved.

[jmesserly]

fyi, I'm working (slowly) on these.

More discussion of the type promotion ones is in this (closed) bug: dart-archive/dev_compiler#343

What is happening is there was no type promotion going on at all. Instead because "var" means "dynamic" in Dart, all warnings are suppressed. And the reason type promotion is disabled is because of an assignment to the variable in a closure, so type promotion doesn't know if the variable has been mutated or not.

With DDC, we infer the type of the "var" and so we start to get warnings.

Anyway I'll see what I can do there. Possibly a tweak to avoid the mutation will make type promotion work as expected.