Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration_test failing on Dart SDK main due to recent pub changes #2050

Closed
elliette opened this issue Mar 28, 2023 · 1 comment
Closed

integration_test failing on Dart SDK main due to recent pub changes #2050

elliette opened this issue Mar 28, 2023 · 1 comment
Labels
package:webdev

Comments

@elliette
Copy link
Contributor

Some of the webdev integration_test cases are failing on the main branch of the Dart SDK, most likely due to dart-lang/pub#3844

These test cases seem to actually be testing pub validation, and string matching against the validation messages generated by pub. I don't think this is useful for us to test. We probably want to change the integration_test to actually test the validation that we control.
@elliette elliette mentioned this issue Mar 28, 2023
Merged
@elliette elliette mentioned this issue Apr 4, 2024
Merged
@bkonyi
Copy link
Collaborator

bkonyi commented Oct 2, 2024

Is this still relevant @elliette?

@bkonyi bkonyi closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:webdev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elliette @bkonyi