Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of .__proto__ from JS code #2118

Closed
annagrin opened this issue May 16, 2023 · 2 comments · Fixed by #2500
Closed

Remove uses of .__proto__ from JS code #2118

annagrin opened this issue May 16, 2023 · 2 comments · Fixed by #2500
Assignees
Labels
P2 A bug or feature request we're likely to work on triaged

Comments

@annagrin
Copy link
Contributor

annagrin commented May 16, 2023

We currently have a case where we call __proto__ to determine if the object is a plain JS object:

Use of __proto__ should be replaced by Object.getPrototypeOf(#)`. Or maybe we can use the object runtime metadata to determine its type?

See more information in dart-lang/sdk#52372

if (!(this.__proto__)) { return 'Instance of PlainJavaScriptObject';}

@bkonyi bkonyi added P2 A bug or feature request we're likely to work on triaged labels Sep 25, 2024
@jyameo
Copy link
Contributor

jyameo commented Sep 30, 2024

Is this a duplicate issue of dart-lang/sdk#52372? Looks like the issue has already been closed.

@bkonyi
Copy link
Collaborator

bkonyi commented Sep 30, 2024

I don't think so. There's still references to this.__proto__ in DWDS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants