Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use snake_case for property #237

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Apr 29, 2021

Issue being fixed or feature implemented

Smoke test was failing with AssertionError: expected { Object (version, time, ...) } to have property 'sync_progress'

What was done?

Change property syntax to syncProgress

How Has This Been Tested?

On palinka

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.19 milestone Apr 29, 2021
@strophy strophy requested a review from shumkov April 29, 2021 17:48
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@strophy strophy merged commit aa31dfc into v0.19-dev Apr 29, 2021
@strophy strophy deleted the fix-property-case branch April 29, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants