Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate tenderdash 0.4.x #238

Merged
merged 42 commits into from
Jun 18, 2021
Merged

feat: integrate tenderdash 0.4.x #238

merged 42 commits into from
Jun 18, 2021

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented May 26, 2021

Issue being fixed or feature implemented

Tenderdash 0.4.0 has been released and must be supported in the deploy tool to deploy to Dash networks.

What was done?

Added vars for new image versions

How Has This Been Tested?

Tested on Palinka

Breaking Changes

Will not work with Tenderdash < 0.4.0

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy requested a review from shumkov May 26, 2021 15:58
@strophy strophy added this to the v0.20 milestone May 26, 2021
@strophy
Copy link
Collaborator Author

strophy commented May 26, 2021

Currently failing with:

root@masternode-42:/dash/mn_evo_services# docker logs mn_evo_services_tendermint_1
LoadState: Data has been corrupted or its spec has changed:
		proto: wrong wireType = 0 for field LastAppHash\n
LoadState: Data has been corrupted or its spec has changed:
		proto: wrong wireType = 0 for field LastAppHash\n

@shumkov shumkov changed the title chore: update to support tenderdash 0.4.0 feat: integrate tenderdash 0.4.0 Jun 4, 2021
@strophy strophy mentioned this pull request Jun 16, 2021
Closed
8 tasks
@strophy
Copy link
Collaborator Author

strophy commented Jun 16, 2021

Merged #239 to this PR

strophy
strophy commented Jun 16, 2021
View reviewed changes
ansible/deploy.yml Outdated Show resolved Hide resolved
shumkov
shumkov reviewed Jun 16, 2021
View reviewed changes
ansible/roles/mn-evo-services/templates/tendermint/config.toml.j2 Outdated Show resolved Hide resolved
ansible/deploy.yml Outdated Show resolved Hide resolved
@strophy
Copy link
Collaborator Author

strophy commented Jun 17, 2021

Blocks are now set to 2100. I found the bug in the masternode config logic, running through entire tool one more time for testing now

@strophy strophy changed the title feat: integrate tenderdash 0.4.0 feat: integrate tenderdash 0.4.x Jun 17, 2021
@strophy strophy marked this pull request as ready for review June 17, 2021 14:00
@strophy strophy requested a review from shumkov June 17, 2021 14:00
shumkov
shumkov requested changes Jun 17, 2021
View reviewed changes
ansible/roles/insight/tasks/main.yml Outdated Show resolved Hide resolved
shumkov
shumkov approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@strophy strophy merged commit 77c5369 into v0.20-dev Jun 18, 2021
@strophy strophy deleted the update-tenderdash-0.4.0 branch June 18, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20
Development

Successfully merging this pull request may close these issues.
2 participants
@strophy @shumkov