Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate command not found with core 18.1.0 #297

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented May 20, 2022

Issue being fixed or feature implemented

dash-cli generate returns error message: Method not found with 18.1.x builds of Dash Core

What was done?

Replace generate with generatetoaddress, this command is backwards compatible so older versions of core should still work when runnings tasks that require blocks to be created.

How Has This Been Tested?

Tested while deploying a devnet with the latest core build on devnet-jammy, a small devnet to test updating the Ubuntu base image.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.23.0 milestone May 20, 2022
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit b492af2 into v0.23-dev May 20, 2022
@shumkov shumkov deleted the fix-generate branch May 20, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants