-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: do not allow contested documents for the first three epochs #2066
Merged
QuantumExplorer
merged 18 commits into
v1.1-dev
from
chore/drive/disable-contested-documents
Aug 24, 2024
Merged
chore!: do not allow contested documents for the first three epochs #2066
QuantumExplorer
merged 18 commits into
v1.1-dev
from
chore/drive/disable-contested-documents
Aug 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumExplorer
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add at the SDK level that it stops you from sending.
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Outdated
Show resolved
Hide resolved
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Outdated
Show resolved
Hide resolved
...validation/state_transition/common/validate_temporary_disabled_contested_documents/v0/mod.rs
Outdated
Show resolved
Hide resolved
...validation/state_transition/common/validate_temporary_disabled_contested_documents/v0/mod.rs
Outdated
Show resolved
Hide resolved
...n/validation/state_transition/state_transitions/documents_batch/advanced_structure/v0/mod.rs
Outdated
Show resolved
Hide resolved
shumkov
commented
Aug 22, 2024
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Outdated
Show resolved
Hide resolved
...ages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs
Outdated
Show resolved
Hide resolved
...n/validation/state_transition/state_transitions/documents_batch/advanced_structure/v0/mod.rs
Outdated
Show resolved
Hide resolved
QuantumExplorer
requested changes
Aug 23, 2024
packages/rs-drive-abci/src/execution/validation/state_transition/processor/v0/mod.rs
Outdated
Show resolved
Hide resolved
QuantumExplorer
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix clippy warnings.
QuantumExplorer
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Mobile wallets aren't ready for activation date. That will enable unfair benefit for technical people who could take usernames without mobile applications. We need to delay username distribution until the point when we have both iOS and Android apps ready.
What was done?
How Has This Been Tested?
Breaking Changes
State transition validation rules are changed so previously created blockchain data might not be valid.
Checklist:
For repository code-owners and collaborators only