Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: do not allow contested documents for the first three epochs #2066

Merged
merged 18 commits into from
Aug 24, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 21, 2024

Issue being fixed or feature implemented

Mobile wallets aren't ready for activation date. That will enable unfair benefit for technical people who could take usernames without mobile applications. We need to delay username distribution until the point when we have both iOS and Android apps ready.

What was done?

  • Reject DocumentsBatchTransition with the 10418 code if it's contained a contested document create transition.
  • Allow to pass identities to the continue chain in strategy tests

How Has This Been Tested?

  • Added a strategy tests where we aren't able to create a contested document on the second block but then create it successfully on 4th epoch.

Breaking Changes

State transition validation rules are changed so previously created blockchain data might not be valid.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@QuantumExplorer QuantumExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add at the SDK level that it stops you from sending.

@shumkov shumkov marked this pull request as ready for review August 22, 2024 17:57
@shumkov shumkov changed the title chore: do not allow contested documents for the first two epochs chore: do not allow contested documents for the first two epochs [WIP] Aug 22, 2024
@shumkov shumkov changed the title chore: do not allow contested documents for the first two epochs [WIP] chore: do not allow contested documents for the first three epochs [WIP] Aug 23, 2024
@shumkov shumkov added this to the v1.1.0 milestone Aug 23, 2024
@shumkov shumkov changed the title chore: do not allow contested documents for the first three epochs [WIP] chore!: do not allow contested documents for the first three epochs Aug 23, 2024
Copy link
Member

@QuantumExplorer QuantumExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix clippy warnings.

@QuantumExplorer QuantumExplorer merged commit e6c5bdc into v1.1-dev Aug 24, 2024
75 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/drive/disable-contested-documents branch August 24, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants