Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashmate): compress doctor report and other improvements #2071

Merged
merged 33 commits into from
Aug 24, 2024
Merged

feat(dashmate): compress doctor report and other improvements #2071

merged 33 commits into from
Aug 24, 2024

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Aug 23, 2024 •
edited by shumkov
Loading

Issue being fixed or feature implemented

According to the feedback from colleges we identified several potential improvements

What was done?

  1. Compress report file
  2. Use the quorum listextended RPC
  3. Remove unnecessary obfuscation

How Has This Been Tested?

Running locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

pshenmic and others added 30 commits July 30, 2024 18:09
@pshenmic
chore(dashmate): add node-tar
f7891c6
@pshenmic
chore(dashmate): add dashmate doctor command
ac9ff31
@pshenmic
chore(dashmate): refactor doctor command
fa498c9
@pshenmic
chore(dashmate): update command title
94577cf
@pshenmic
chore(dashmate): update documentation
08cb70e
@pshenmic
chore(dashmate): update documentation
531c402
@pshenmic
chore(dashmate): refactor verifySystemRequirementsTaskFactory.js
5a538fb
@pshenmic
chore(dashmate): fix bold
592a11d
@pshenmic
Merge remote-tracking branch 'origin/v1.0-dev' into feat/dashmate-report
9a02692
@pshenmic @shumkov
Update packages/dashmate/src/commands/doctor.js
1b18c5f 
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@pshenmic
fix(dashmate): add missing services in getServiceList
9ffa9db
@pshenmic
Merge remote-tracking branch 'origin/feat/dashmate-report' into feat/…
d911d6f 
…dashmate-report
@pshenmic
feat(dashmate): code review fixes
d5fe4dc
@pshenmic
feat(dashmate): add sanitize dashmate config
e8cc456
@pshenmic
feat(dashmate): break down doctor.js in listr tasks
678a587
@pshenmic
feat(dashmate): add collecting data prompt
d1c62a6
@pshenmic
feat(dashmate): add colors
43c61af
@shumkov
chore: prettify listr
c7a6531
@shumkov
chore: remove sensitive information from report
1b44bf1
@shumkov
refactor: remove fetch HTTP
fd89698
@shumkov
refactor: use chalk template
c90abfd
@pshenmic
feat(dashmate): update yarn cache
9651fcd
@pshenmic
feat(dashmate): obfuscate user & externalIp
b8f08dd
@pshenmic
feat(dashmate): code review fixes
0fd553e
@pshenmic
feat(dashmate): fix elliptic audit
48241de
@pshenmic
feat(dashmate): fix elliptic audit
f1c9149
@pshenmic
feat(dashmate): fix micromatch audit
3be5482
@pshenmic
feat(dashmate): add gzip compression
57775bd
@pshenmic
feat(dashmate): use listextended for quorums info
3345327
@pshenmic
feat(dashmate): obfuscate node key
0d9e89b
@pshenmic
feat(dashmate): obfuscate node id and protxhash from the status
c94bc23
@pshenmic
Merge remote-tracking branch 'origin/v1.1-dev' into feat/dashmate-report
f5a5c1c 
# Conflicts:
#	.yarnrc.yml
#	packages/dashmate/src/commands/doctor.js
#	packages/dashmate/src/config/obfuscateConfig.js
#	packages/dashmate/src/doctor/report.js
@pshenmic pshenmic marked this pull request as draft August 23, 2024 09:35
@pshenmic pshenmic changed the title Feat/dashmate report chore(dashmate): obfuscation fixes Aug 23, 2024
shumkov
shumkov reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: remove unnecessary obfuscation

@shumkov shumkov changed the title chore(dashmate): obfuscation fixes chore(dashmate): compress doctor report Aug 23, 2024
@shumkov shumkov changed the base branch from v1.1-dev to v1.2-dev August 24, 2024 06:12
@shumkov shumkov changed the title chore(dashmate): compress doctor report feat(dashmate): compress doctor report and other improvements Aug 24, 2024
@shumkov shumkov marked this pull request as ready for review August 24, 2024 06:16
@shumkov shumkov changed the base branch from v1.2-dev to v1.1-dev August 24, 2024 06:35
shumkov
shumkov approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pshenmic pshenmic self-assigned this Aug 24, 2024
@shumkov shumkov merged commit d48b399 into v1.1-dev Aug 24, 2024
38 checks passed
@shumkov shumkov deleted the feat/dashmate-report branch August 24, 2024 08:41
@thephez thephez added this to the v1.1.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees

@pshenmic pshenmic

Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pshenmic @shumkov @thephez