From b9a46886289939b86fdcb83ddd9e2424c88dcc99 Mon Sep 17 00:00:00 2001 From: Ayobami Akingbade Date: Mon, 26 Sep 2022 00:17:28 +0100 Subject: [PATCH] feat: handling sqlite connection more gracefully --- package.json | 2 +- src/backend/lib/connection/db.ts | 1 + src/frontend/views/setup/Credentials/Form.tsx | 10 ++++++---- src/shared/types/data-sources.ts | 6 +++--- yarn.lock | 8 ++++---- 5 files changed, 15 insertions(+), 12 deletions(-) diff --git a/package.json b/package.json index 94e6b4d95..581cc806f 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,7 @@ ], "bin": "./bin/hadmean", "dependencies": { - "@hadmean/bacteria": "^0.0.1", + "@hadmean/bacteria": "^0.0.3", "@hadmean/chromista": "^1.0.28", "@hadmean/protozoa": "^1.0.8", "@types/cryptr": "^4.0.1", diff --git a/src/backend/lib/connection/db.ts b/src/backend/lib/connection/db.ts index cc6fc8c5b..391cfd6d0 100644 --- a/src/backend/lib/connection/db.ts +++ b/src/backend/lib/connection/db.ts @@ -43,6 +43,7 @@ const make = (credentials: IDataSourceCredentials | string) => { user: credentials.user, password: credentials.password, host: credentials.host, + filename: credentials.filename, port: credentials.port, ssl: credentials.ssl, }, diff --git a/src/frontend/views/setup/Credentials/Form.tsx b/src/frontend/views/setup/Credentials/Form.tsx index 5042b59b5..e50ba56dd 100644 --- a/src/frontend/views/setup/Credentials/Form.tsx +++ b/src/frontend/views/setup/Credentials/Form.tsx @@ -23,7 +23,9 @@ export function CredentialsSetupForm({ port: Object.values(DATA_SOURCES_CONFIG)[0].port, }} render={({ handleSubmit, submitting, pristine, form, values }) => { - const dataSourceConfig = DATA_SOURCES_CONFIG[values.dataSourceType]; + const dataSourceConfig = DATA_SOURCES_CONFIG[values.dataSourceType] || { + fields: [], + }; return (
)} - {dataSourceConfig.fields.includes("path") && ( - + {dataSourceConfig.fields.includes("filename") && ( + {({ input, meta }) => ( - + )} )} diff --git a/src/shared/types/data-sources.ts b/src/shared/types/data-sources.ts index 4eadcb32d..a29e4db84 100644 --- a/src/shared/types/data-sources.ts +++ b/src/shared/types/data-sources.ts @@ -11,14 +11,14 @@ export type IDataSourceCredentials = { host: string; user: string; password: string; - path: string; + filename: string; schemaNames: string[]; database: string; port: number; ssl: boolean; }; -const DATABASE_FIELDS: Array = [ +const DATABASE_FIELDS: Array = [ "host", "user", "password", @@ -47,6 +47,6 @@ export const DATA_SOURCES_CONFIG: Record< port: 3306, }, [SupportedDataSources.Sqlite]: { - fields: ["path"], + fields: ["filename"], }, }; diff --git a/yarn.lock b/yarn.lock index 71f892e57..225a9e641 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1431,10 +1431,10 @@ resolved "https://registry.npmjs.org/@gar/promisify/-/promisify-1.1.3.tgz" integrity sha512-k2Ty1JcVojjJFwrg/ThKi2ujJ7XNLYaFGNB/bWT9wGR+oSMJHMa5w+CUq6p/pVrKeNNgA7pCqEcjSnHVoqJQFw== -"@hadmean/bacteria@^0.0.1": - version "0.0.1" - resolved "https://registry.npmjs.org/@hadmean/bacteria/-/bacteria-0.0.1.tgz" - integrity sha512-amcxl7M8LyU4ps12MryklhcdT6IO8lgiPbGNFSrsYEagHs8L9ZsjFyEa6eHsUbbQ8t9oIQTcCjqukGcpUNf7sA== +"@hadmean/bacteria@^0.0.3": + version "0.0.3" + resolved "https://registry.yarnpkg.com/@hadmean/bacteria/-/bacteria-0.0.3.tgz#3092fc320d6d3cbdfa591c7448152baf1f91068a" + integrity sha512-pRe1qHYY9axN5v03zYJeXyIdxyCcX4SqKejqtgdMD1smyaa/sD7/KNu0zinoingrvYp0UByusDDieAK+IzLkXA== dependencies: "@types/fs-extra" "^9.0.13" "@types/mssql" "^8.0.3"