See what happens if we ignore libprotobuf's runtime exports
#1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
reviewed
Oct 12, 2023
| @@ -48,6 +48,9 @@ requirements: | |||
| - pygments >=2.7.1 | |||
| - tabulate | |||
|
|
|||
| ignore_run_exports: | |||
There was a problem hiding this comment.
Does this have to go in the top level build key? https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#export-runtime-requirements
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1242 +/- ##
==========================================
+ Coverage 81.58% 81.69% +0.10%
==========================================
Files 78 78
Lines 4611 4611
Branches 854 854
==========================================
+ Hits 3762 3767 +5
+ Misses 660 651 -9
- Partials 189 193 +4 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring alternatives to conda-forge/dask-sql-feedstock#74
cc @bdice @jakirkham