Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2022.5.0 #267

Closed
thomafred opened this issue May 13, 2022 · 13 comments
Closed

Release 2022.5.0 #267

thomafred opened this issue May 13, 2022 · 13 comments

Comments

@thomafred
Copy link

Kubernetes v1.22 requires spec.versions.schema to be set (link to docs). See dask/dask-gateway#434

Master-branch is already updated, so simply releasing a new version of the helm-chart daskhub would fix this issue.

As the helm-chart stands now, the daskhub helm-chart will not work on kubernetes v1.22 and above.

@jacobtomlinson
Copy link
Member

The next Dask release is imminent, you can track it here dask/community#245

@chadsr
Copy link

chadsr commented May 25, 2022

I see dask/community#245 is released now. Any status on a release for the helm charts to fix this?

@jacobtomlinson
Copy link
Member

Releases here are automated, a bot should open a PR once things have updated in the Conda Forge cache.

@consideRatio
Copy link
Collaborator

@jacobtomlinson hmmm, they are automated to the extent that if you push a tag, they happen as I understand it.

name: Publish charts
on:
push:
tags: ["*"]
workflow_dispatch:

You pushed the latest tag in this repo, see https://github.com/dask/helm-chart/releases/tag/2022.4.1. Is that a tag that was pushed automatically somehow?

@jacobtomlinson
Copy link
Member

I meant bumping the Dask versions is automated, and then I push a tag after that. The bumping versions automation doesn't seem to have run though for 2022.5.1.

@consideRatio
Copy link
Collaborator

The bumping versions automation doesn't seem to have run though for 2022.5.1.

I'll look into this!

@consideRatio
Copy link
Collaborator

consideRatio commented May 25, 2022

image

# ref: https://github.com/jacobtomlinson/gha-find-replace
- name: Replace old appVersion with new in dask chart
uses: jacobtomlinson/gha-find-replace@2.0.0
with:
include: "dask/"
find: "${{ steps.dask_chart.outputs.appVersion }}"
replace: "${{ steps.latest.outputs.tag }}"

Hmm... I don't get this. Is there a bug in the replace action? I get hits on 2022.5.0 when I checkout this repo and search for 2022.5.0 in the dask/ folder.

tag: "2022.5.0" # Container image tag.

Is it because I have put quotes around this string in https://github.com/dask/helm-chart/pull/271/files? I did so to protect against possible issues that can arise if one has a tag like 3.10 or similar that YAML would interpret as the number 3.1

@consideRatio
Copy link
Collaborator

It could also be a regression in #248, I'm not sure.

@TomAugspurger
Copy link
Member

TomAugspurger commented May 26, 2022

#275, #276, and #277 got the updates working again I think. So to trigger a release, we make a tag? @jacobtomlinson do you want to handle that, or are you OK with any maintainer pushing / making the tag?

@jacobtomlinson
Copy link
Member

Any maintainer can do it ☺️. But if nobody has when I have some free time later today I'll do it then.

@chadsr
Copy link

chadsr commented May 31, 2022

Glad you fixed up the release actions ☺️
Just a headsup, there isn't yet a tag for 2022.5.x, so publish-charts.yml hasn't triggered.

@jacobtomlinson
Copy link
Member

Thanks for the nudge @chadsr I forgot to circle back. I just tagged 2022.5.0.

@TomAugspurger
Copy link
Member

Thanks Jacob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants