Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deprecated is_datetime64tz_dtype from pandas #67

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Avoid deprecated is_datetime64tz_dtype from pandas #67

merged 1 commit into from
Apr 17, 2023

Conversation

jrbourbeau
Copy link
Member

Currently the test suite gives

partd/tests/test_pandas.py: 17 warnings
  /Users/james/projects/dask/partd/partd/pandas.py:141: FutureWarning: is_datetime64tz_dtype is deprecated and will be removed in a future version. Check `isinstance(dtype, pd.DatetimeTZDtype)` instead.
    elif is_datetime64tz_dtype(block):

when run against the latest nightly pandas wheel due to is_datetime64tz_dtype being deprecated upstream. It's now recommended to just do a isinstance(..., pd.DatetimeTZDtype) check instead

xref pandas-dev/pandas#52607

cc @j-bennet @phofl

@jrbourbeau jrbourbeau merged commit 9db50c1 into dask:main Apr 17, 2023
@jrbourbeau jrbourbeau deleted the is_datetime64tz_dtype branch April 17, 2023 21:31
@j-bennet j-bennet mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrbourbeau @phofl