Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

leave vs close connections #27

Open
joehand opened this issue May 22, 2019 · 1 comment
Open

leave vs close connections #27

joehand opened this issue May 22, 2019 · 1 comment

Comments

@joehand
Copy link
Collaborator

joehand commented May 22, 2019

Closing the connection isn't the same behavior as discovery swarm. I think it might be nice to keep the api consistent, there are use cases where you want to stop announcing but still keep connections open. 'close' or "destroy" can be the thing that kills the connections as well as stops announcing.

We could use close/destroy but would need to have an API for destroing single feed vs the whole swarm.

@okdistribute
Copy link
Collaborator

i think its okay to just close the whole swarm and if you want to close a particular feed you can do that using the swarm.connections

let's try to minimize the amount of extra api work we're doing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants