Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xp.linalg.vecdot should have axis=-1 default #804

Open
oleksandr-pavlyk opened this issue May 3, 2024 · 1 comment
Open

xp.linalg.vecdot should have axis=-1 default #804

oleksandr-pavlyk opened this issue May 3, 2024 · 1 comment
Labels
Backport Changes involve backporting to previous versions. bug Something isn't working.
Milestone
v2024

Comments

@oleksandr-pavlyk
Copy link
Contributor

xp.linalg.vecdot is documented as alias to xp.vecdot.

However, xp.linalg.vecdot signature uses axis=None default, while xp.vecdot has axis=-1 as the default.

image

image

They should be consistent.
@kgryte
Copy link
Contributor

kgryte commented May 3, 2024

Hmmm...this should have been fixed already: #355. The regression happened during cbbab62. I can work on a fix and backport.

@kgryte kgryte added bug Something isn't working. Backport Changes involve backporting to previous versions. labels May 3, 2024
@kgryte kgryte added this to the v2024 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backport Changes involve backporting to previous versions. bug Something isn't working.
Projects
None yet
Milestone
v2024
Development

No branches or pull requests
2 participants
@kgryte @oleksandr-pavlyk