Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve insert into performance #4413

Closed
sundy-li opened this issue Mar 12, 2022 · 2 comments · Fixed by #4497
Closed

Feature: Improve insert into performance #4413

sundy-li opened this issue Mar 12, 2022 · 2 comments · Fixed by #4497
Assignees
Labels
C-feature Category: feature community-take good first issue Category: good first issue
Milestone

Comments

@sundy-li
Copy link
Member

Summary

Description for this feature.

Query:

INSERT INTO `books` VALUES ('Transaction Processing','Jim Gray', 1992),('Readings in Database Systems','Michael Stonebraker', 2004);

The entire SQL goes into SQL parser and expression-executor, because we can have expression inside VALUES, eg:

INSERT INTO `books` VALUES ('Transaction Processing','Jim Gray', now() - 3),('Readings in Database Systems','Michael Stonebraker', 2004);

To support expressions, this insert SQL works really slow. We can improve the performance by:

  1. Use source_values by default.
  2. If error happens, fall back to current way.
@sundy-li sundy-li added C-feature Category: feature good first issue Category: good first issue labels Mar 12, 2022
@ygf11
Copy link
Contributor

ygf11 commented Mar 12, 2022

/assignme

@ygf11
Copy link
Contributor

ygf11 commented Mar 30, 2022

@sundy-li I find a way to address the lifetime, will create a draft pr soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature community-take good first issue Category: good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants