Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all the KV from serde to protobuf #5221

Closed
BohuTANG opened this issue May 7, 2022 · 0 comments
Closed

Change all the KV from serde to protobuf #5221

BohuTANG opened this issue May 7, 2022 · 0 comments
Assignees
@flaneur2020 @lichuang
Labels
C-improvement Category: improvement

Comments

@BohuTANG
Copy link
Member

BohuTANG commented May 7, 2022

Summary

MetaAPI has moved from serde to protobuf based on KV API for compatibility, thanks @drmingdrmer .
It also needs to move serde to protobuf for query/user.
For backward compatibility, we should first try to deserialize the value with protobuf, if it errors then try to deserialize it with serde.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaneur2020 flaneur2020

@lichuang lichuang

Labels
C-improvement Category: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flaneur2020 @BohuTANG @lichuang