Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: SQLCommon::short_sql does not trim insert stmt as expected #6132

Closed
dantengsky opened this issue Jun 22, 2022 · 2 comments · Fixed by #6135
Closed

BUG: SQLCommon::short_sql does not trim insert stmt as expected #6132

dantengsky opened this issue Jun 22, 2022 · 2 comments · Fixed by #6135
Assignees
Labels
C-bug Category: something isn't working C-feature Category: feature

Comments

@dantengsky
Copy link
Member

Summary

SQLCommon::short_sql is expected to trim insert SQL to string, which length is at most 64.

but, it does not.

How to reproduce:

  • execute a long insert sql
  • select the query log from system.query_log
    e.g. select * from system.query_log where query_text like "insert%"
@dantengsky dantengsky added the C-feature Category: feature label Jun 22, 2022
@BohuTANG BohuTANG added the C-bug Category: something isn't working label Jun 22, 2022
@BohuTANG
Copy link
Member

Add a new QueryConfig for query_log name like query_log_enabled (default is true)?

@BohuTANG
Copy link
Member

Add a new QueryConfig for query_log name like query_log_enabled (default is true)?

It seems max_query_log_size=0 can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: something isn't working C-feature Category: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants