Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split databend-query to multiple crates #6180

Closed
PsiACE opened this issue Jun 23, 2022 · 6 comments
Closed

split databend-query to multiple crates #6180

PsiACE opened this issue Jun 23, 2022 · 6 comments
Labels
C-improvement Category: improvement make-life-easy Make the databend core team life easier prio: normal Medium priority

Comments

@PsiACE
Copy link
Member

PsiACE commented Jun 23, 2022

Summary

Now Databend-Query is a rather large crate and we had to waste a lot of time on compiling and linking.

It's time to split it up into a few relatively small crates.

Related #4399

@PsiACE PsiACE added prio: high High priority C-improvement Category: improvement make-life-easy Make the databend core team life easier labels Jun 23, 2022
@PsiACE PsiACE self-assigned this Jun 23, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Jun 23, 2022

It's very important to do this job in a progressive way. Otherwise, we can't finish it.

@Xuanwo
Copy link
Member

Xuanwo commented Jun 23, 2022

#4399 is a good example: It starts three months ago and ends with numerous code conflicts...

@PsiACE
Copy link
Member Author

PsiACE commented Jun 23, 2022

It's very important to do this job in a progressive way. Otherwise, we can't finish it.

Yes, we're having trouble finding a window to do it all at once, and I think it will probably be done in two or three rounds.

@FANNG1
Copy link

FANNG1 commented Jul 5, 2022

code one minute, cargo check ten minutes :(

@PsiACE
Copy link
Member Author

PsiACE commented Jul 19, 2022

Although there is more that could be split, I thought we'd stop and wait for the new planner to be officially launched (#6644) so that we could get rid of the old useless code and determine how to refactor this further.

After #6665, my local build/check speed got a boost and returned to at least usable levels.

@Xuanwo
Copy link
Member

Xuanwo commented Oct 27, 2022

Implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-improvement Category: improvement make-life-easy Make the databend core team life easier prio: normal Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants