-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fuse table lost DalContext layer bind #8331
Labels
C-bug
Category: something isn't working
Comments
Can each operator(DataOperator/CacheOpeator) has his metrics and get them from the query? cc @Xuanwo |
We can put a
|
@BohuTANG Are you still working on this? |
2 tasks
#8345 should address this issue. |
No. |
This was referenced Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
After refactoring a few days ago, now the fuse table storage operator init:
https://github.com/datafuselabs/databend/blob/c0030eb977b4e2fee50d464c749f240ed044ad0f/src/query/storages/fuse/src/fuse_table.rs#L88-L113
We can not get the metrics from DalContext.
By design, it should be:
https://github.com/datafuselabs/databend/blob/c0030eb977b4e2fee50d464c749f240ed044ad0f/src/query/service/src/sessions/query_ctx.rs#L311-L319
After refactoring, putting dal_ctx in the query context is not right, it looks every operator(DataOperator/CacheOpeartor) should have his metrics and get them from the Query Context.
The text was updated successfully, but these errors were encountered: