Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fuse table lost DalContext layer bind #8331

Closed
BohuTANG opened this issue Oct 20, 2022 · 5 comments · Fixed by #8363
Closed

bug: fuse table lost DalContext layer bind #8331

BohuTANG opened this issue Oct 20, 2022 · 5 comments · Fixed by #8363
Assignees
Labels
C-bug Category: something isn't working

Comments

@BohuTANG
Copy link
Member

BohuTANG commented Oct 20, 2022

Summary

After refactoring a few days ago, now the fuse table storage operator init:
https://github.com/datafuselabs/databend/blob/c0030eb977b4e2fee50d464c749f240ed044ad0f/src/query/storages/fuse/src/fuse_table.rs#L88-L113

We can not get the metrics from DalContext.

By design, it should be:
https://github.com/datafuselabs/databend/blob/c0030eb977b4e2fee50d464c749f240ed044ad0f/src/query/service/src/sessions/query_ctx.rs#L311-L319

After refactoring, putting dal_ctx in the query context is not right, it looks every operator(DataOperator/CacheOpeartor) should have his metrics and get them from the Query Context.

@BohuTANG BohuTANG added the C-bug Category: something isn't working label Oct 20, 2022
@BohuTANG
Copy link
Member Author

BohuTANG commented Oct 20, 2022

Can each operator(DataOperator/CacheOpeator) has his metrics and get them from the query? cc @Xuanwo

@BohuTANG
Copy link
Member Author

BohuTANG commented Oct 20, 2022

We can put a DalContext like this to get fuse engine read/write metrics:

query_ctx.build_table_by_table_info --> catalog.get_table_by_info --> fuse_storage.get_table --> fusetable.try_create --> operator().layer(ctx)

@Xuanwo
Copy link
Member

Xuanwo commented Oct 20, 2022

@BohuTANG Are you still working on this?

@Xuanwo
Copy link
Member

Xuanwo commented Oct 20, 2022

#8345 should address this issue.

@BohuTANG
Copy link
Member Author

@BohuTANG Are you still working on this?

No.

@Xuanwo Xuanwo assigned Xuanwo and unassigned BohuTANG Oct 20, 2022
@Xuanwo Xuanwo moved this to 📋 Backlog in Xuanwo's Work Oct 20, 2022
@Xuanwo Xuanwo moved this from 📋 Backlog to 📦 Done in Xuanwo's Work Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: something isn't working
Projects
None yet
2 participants