Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider revert DashMap #8744

Closed
zhang2014 opened this issue Nov 11, 2022 · 7 comments
Closed

Consider revert DashMap #8744

zhang2014 opened this issue Nov 11, 2022 · 7 comments

Comments

@zhang2014
Copy link
Member

Summary
DashMap will introduce gc threads. If it's not necessary, maybe we should consider revert it.

image

@zhang2014 zhang2014 changed the title Revert DashMap Consider revert DashMap Nov 11, 2022
@PsiACE
Copy link
Member

PsiACE commented Nov 11, 2022

DashMap will introduce gc threads. If it's not necessary, maybe we should consider revert it.

https://github.com/moka-rs/moka

It looks like a moka problem, may need set thread_pool_enabled to false using the cache builder.

moka-rs/moka#154 (comment)

cc @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Nov 11, 2022

We can fix this on the opendal side. @PsiACE Do you want to do this?

@PsiACE
Copy link
Member

PsiACE commented Nov 11, 2022

We can fix this on the opendal side. @PsiACE Do you want to do this?

OK, I'll check it out and it looks like I can add a new parameter to the Builder

@Xuanwo
Copy link
Member

Xuanwo commented Nov 11, 2022

OK, I'll check it out and it looks like I can add a new parameter to the Builder

We can just disable it directly and add it back if users need this.

@PsiACE
Copy link
Member

PsiACE commented Nov 11, 2022

We can just disable it directly and add it back if users need this.

oops, it looks like we're using moka::future::Cache, this option doesn't work, I'll check again. 😢 :

@Xuanwo
Copy link
Member

Xuanwo commented Nov 11, 2022

Maybe we can replace future::Cache with sync::SegmentedCache or dash::Cach

@Xuanwo
Copy link
Member

Xuanwo commented Nov 14, 2022

Already addressed.

@Xuanwo Xuanwo closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants