Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable runtime filter when join_spilling_memory_ratio !=0 #14959

Merged
merged 4 commits into from
Mar 15, 2024
Merged

fix: enable runtime filter when join_spilling_memory_ratio !=0 #14959

merged 4 commits into from
Mar 15, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Mar 15, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Due to the join spilling opened by default which makes runtime filter closed.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@xudong963 xudong963 added the ci-benchmark Benchmark: run all test label Mar 15, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 15, 2024
@xudong963 xudong963 marked this pull request as draft March 15, 2024 04:05
@databendlabs databendlabs deleted a comment from github-actions bot Mar 15, 2024
@databendlabs databendlabs deleted a comment from github-actions bot Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14959-1f231cf

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@xudong963 xudong963 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Mar 15, 2024
@databendlabs databendlabs deleted a comment from github-actions bot Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14959-bfee0c8

note: this image tag is only available for internal use,
please check the internal doc for more details.

@xudong963 xudong963 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14959-672aa4c

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@xudong963 xudong963 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Mar 15, 2024
@xudong963 xudong963 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Mar 15, 2024
@xudong963 xudong963 changed the title chore: test q17 chore: enable runtime filter when join_spilling_memory_ratio !=0 Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14959-c26cbbd

note: this image tag is only available for internal use,
please check the internal doc for more details.

@xudong963 xudong963 marked this pull request as ready for review March 15, 2024 09:51
@xudong963 xudong963 requested review from Dousir9 and JackTan25 March 15, 2024 09:51
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14959-03f93dc

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@xudong963 xudong963 changed the title chore: enable runtime filter when join_spilling_memory_ratio !=0 fix: enable runtime filter when join_spilling_memory_ratio !=0 Mar 15, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 15, 2024
@xudong963 xudong963 enabled auto-merge March 15, 2024 10:06
@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@xudong963 xudong963 added this pull request to the merge queue Mar 15, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 15, 2024
@BohuTANG BohuTANG merged commit c50606c into databendlabs:main Mar 15, 2024
101 checks passed
@BohuTANG
Copy link
Member

Still need a sql logic test to check the runtime filter. cc @xudong963

@xudong963
Copy link
Member Author

Still need a sql logic test to check the runtime filter. cc @xudong963

on the way

@xudong963 xudong963 deleted the test_q17 branch March 15, 2024 13:54
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@Dousir9 Dousir9 Awaiting requested review from Dousir9

@JackTan25 JackTan25 Awaiting requested review from JackTan25

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-bugfix this PR patches a bug in codebase pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xudong963 @BohuTANG