refactor: add generic CrudMgr to implement various simple CRUD manager #14988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
`CrudMgr` is a generic CRUD interface for meta data operations. - It provide `add`, `update`, `get`, `remove` and `list` operations. - The key space it operates on is defined by the type `TIdent<R>` which contains a `Tenant` and a `Name`. - `R: TenantResource` contains essential information for such a CRUD manger, including key prefix, value type, and customizable error for unknown record and existing record. - A `CrudMgr` instance can only access keys of exactly one [`Tenant`].
drmingdrmer
force-pushed
the
25-crud-mgr
branch
from
249b23d to
5bceb9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: add generic CrudMgr to implement various simple CRUD manager
CrudMgris a generic CRUD interface for meta data operations.It provide
add,update,get,removeandlistoperations.The key space it operates on is defined by the type
TIdent<R>which contains a
Tenantand aName.R: TenantResourcecontains essential information for such a CRUDmanger, including key prefix, value type, and customizable error for
unknown record and existing record.
A
CrudMgrinstance can only access keys of exactly one [Tenant].Tests
Type of change
Related Issues
This change is