Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(executor): globalize QueriesPipelineExecutor creation method #15129

Merged
merged 11 commits into from
Apr 2, 2024

Conversation

dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Mar 29, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR should not affect currently used executor

After this PR merged:

  1. QueriesPipelineExecutor becomes a global service.
  2. PipelineExecutor acts as a client and QueriesPipelineExecutor acts as a server. PipelineExecutor act a similar role with current using QueryPipelineExeuctor

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 29, 2024
@dqhl76 dqhl76 changed the title refactor: globalize QueriesPipelineExecutor creation method refactor(executor): globalize QueriesPipelineExecutor creation method Mar 29, 2024
@dqhl76 dqhl76 marked this pull request as ready for review March 31, 2024 10:47
@dqhl76 dqhl76 requested a review from zhang2014 March 31, 2024 10:48
@dqhl76 dqhl76 added the ci-benchmark Benchmark: run all test label Mar 31, 2024
Copy link
Contributor

Docker Image for PR

  • tag: pr-15129-de1662a

note: this image tag is only available for internal use,
please check the internal doc for more details.

@dqhl76 dqhl76 removed the ci-benchmark Benchmark: run all test label Mar 31, 2024
…ing executor

Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 marked this pull request as draft March 31, 2024 13:38
…ing executor

Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 marked this pull request as ready for review April 1, 2024 01:33
@zhang2014 zhang2014 enabled auto-merge April 2, 2024 06:18
@zhang2014 zhang2014 disabled auto-merge April 2, 2024 06:24
@dqhl76
Copy link
Collaborator Author

dqhl76 commented Apr 2, 2024

Working on using compile feature to instead of config

@dqhl76 dqhl76 marked this pull request as draft April 2, 2024 06:29
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 marked this pull request as ready for review April 2, 2024 07:06
@zhang2014 zhang2014 enabled auto-merge April 2, 2024 07:07
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@zhang2014 zhang2014 added this pull request to the merge queue Apr 2, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Apr 2, 2024
@BohuTANG BohuTANG merged commit 4107bcf into databendlabs:main Apr 2, 2024
72 checks passed
@dqhl76 dqhl76 deleted the global-init-executor branch April 2, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants