-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(executor): globalize QueriesPipelineExecutor
creation method
#15129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
this PR changes the code base without new features or bugfix
label
Mar 29, 2024
dqhl76
changed the title
refactor: globalize
refactor(executor): globalize Mar 29, 2024
QueriesPipelineExecutor
creation methodQueriesPipelineExecutor
creation method
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
Docker Image for PR
|
BohuTANG
reviewed
Mar 31, 2024
…ing executor Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
…ing executor Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
zhang2014
approved these changes
Apr 2, 2024
Working on using compile feature to instead of config |
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR should not affect currently used executor
After this PR merged:
QueriesPipelineExecutor
becomes a global service.PipelineExecutor
acts as a client andQueriesPipelineExecutor
acts as a server.PipelineExecutor
act a similar role with current usingQueryPipelineExeuctor
Tests
Type of change