-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support expr in values clause of multi table insert #15147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Apr 1, 2024
11 tasks
SkyFan2002
force-pushed
the
insert_first_1
branch
from
April 1, 2024 07:47
9b86d6e
to
61e57ca
Compare
sundy-li
reviewed
Apr 2, 2024
src/query/service/src/interpreters/interpreter_insert_multi_table.rs
Outdated
Show resolved
Hide resolved
SkyFan2002
force-pushed
the
insert_first_1
branch
from
April 2, 2024 02:14
46cd34e
to
5f872ff
Compare
dantengsky
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: dantengsky <dantengsky@gmail.com>
Co-authored-by: dantengsky <dantengsky@gmail.com>
5 tasks
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
While in snowflake
DEFAULT
(represents a default value) and a ident nameddefault
is ambiguous:in our implemention the column name in source of multi-table insert can't be default:
It is recommended to use aliases to bypass this restriction:
Tests
Type of change