feat: add is_attach column to system.tables and disable index creation for attache tables
#16166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantengsky
force-pushed
the
feat-attach-table
branch
from
3827ecc to
f36e6cc
Compare
dantengsky
changed the title
is_attach column to system.tables and disable index creation for attache tablesis_attach column to system.tables and disable index creation for attache tables
github-actions
bot
added
the
pr-feature
dantengsky
changed the title
is_attach column to system.tables and disable index creation for attache tablesis_attach column to system.tables and disable index creation for attache tables
dantengsky
added
pr-chore
dantengsky
changed the title
is_attach column to system.tables and disable index creation for attache tablesis_attach column to system.tables and disable index creation for attache tables
Extract field `is_attache` has been added, thun adjust assertions
|
@hantmac please take a look, thanks |
|
No affect to jdbc. LGTM. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
…ation for attache tables (#16166) * new field `is_attach` in `system.tables` * prevent index creation on attach table * update ut golden file columns_table.txt * Tweak UT `test_simple_sql` Extract field `is_attache` has been added, thun adjust assertions * tweak test `18_0007_privilege_access.result`
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
add
is_attachcolumn tosystem.tablesand disable index creation for attache tablessystem.tablesto indicate if a table was created withATTACH TABLE#16163ATTACH TABLEstmt #16164Tests
Type of change
This change is