Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(metactl): change to subcommands & support transfer-leader #16254

Merged
merged 30 commits into from
Aug 15, 2024

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Aug 15, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

databend-meta command line tools

Usage: databend-metactl [OPTIONS] [COMMAND]

Commands:
  status                 
  export                 
  import                 
  transfer-leader        
  bench-client-num-conn  
  help                   Print this message or the help of the given subcommand(s)

Options:
      --log-level <LOG_LEVEL>                  [default: INFO]
      --grpc-api-address <GRPC_API_ADDRESS>    DEPRECATE: use subcommand instead [env: METASRV_GRPC_API_ADDRESS=] [default: 127.0.0.1:9191]
      --import                                 DEPRECATE: use subcommand instead
      --export                                 DEPRECATE: use subcommand instead
      --raft-dir <RAFT_DIR>                    DEPRECATE: use subcommand instead
      --export-chunk-size <EXPORT_CHUNK_SIZE>  DEPRECATE: use subcommand instead
      --db <DB>                                DEPRECATE: use subcommand instead [default: ]
      --initial-cluster <INITIAL_CLUSTER>      DEPRECATE: use subcommand instead
      --id <ID>                                DEPRECATE: use subcommand instead [default: 0]
  -h, --help                                   Print help (see more with '--help')
  -V, --version                                Print version

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Aug 15, 2024
@everpcpc everpcpc marked this pull request as ready for review August 15, 2024 10:51
@everpcpc everpcpc requested a review from drmingdrmer August 15, 2024 10:51
@everpcpc everpcpc changed the title chore: refactor commands for metactl refactor(metactl): change to subcommands & support transfer-leader Aug 15, 2024
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 15, 2024
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a super nice refinement to the metactl! Love it!

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @everpcpc)

@everpcpc everpcpc added this pull request to the merge queue Aug 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 15, 2024
@everpcpc everpcpc merged commit 43de923 into databendlabs:main Aug 15, 2024
77 checks passed
@everpcpc everpcpc deleted the feat-metactl branch August 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles. pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants