refactor: change DatabaseInfo.meta to SeqV<DatabaseMeta>
#16295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
111-id-u64-prost-message
branch
from
1150d64 to
985264b
Compare
This commit updates `DatabaseInfo.meta` from `DatabaseMeta` to `SeqV<DatabaseMeta>` to store the sequence number alongside the instance. This change improves code clarity and reduces the potential for errors.
drmingdrmer
force-pushed
the
111-id-u64-prost-message
branch
from
985264b to
a6e2cb4
Compare
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: change
DatabaseInfo.metatoSeqV<DatabaseMeta>This commit updates
DatabaseInfo.metafromDatabaseMetatoSeqV<DatabaseMeta>to store the sequence number alongside theinstance. This change improves code clarity and reduces the potential
for errors.
chore: DatabaseIdent does not need to be serde
feat: make Id a prost::Message so that it can be used a meta-service Value
Tests
Type of change
New Feature (non-breaking change which adds functionality)
Refactoring
Related Issues
This change is