Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): add setting external_server_request_retry_times #16307

Merged
merged 12 commits into from
Aug 22, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Aug 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. add setting external_server_request_retry_times and profile the retry counts
  2. fix index_uncheck in nullable type
🐳 :) explain analyze select gcd_error(1,100) from numbers(3);
-[ EXPLAIN ]-----------------------------------
Udf
├── output columns: [gcd_error(1, 100)_arg_0 (#2), gcd_error(1, 100)_arg_1 (#3), gcd_error(1, 100) (#1)]
├── estimated rows: 3.00
├── cpu time: 6.427012ms
├── wait time: 2.031678683s
├── output rows: 3
├── output bytes: 21.00 B
├── external server retry count: 4
├── udf functions: gcd_error(gcd_error(1, 100)_arg_0 (#2), gcd_error(1, 100)_arg_1 (#3))
└── EvalScalar
    ├── output columns: [gcd_error(1, 100)_arg_0 (#2), gcd_error(1, 100)_arg_1 (#3)]
    ├── expressions: [1, 100]
    ├── estimated rows: 3.00
    ├── cpu time: 44.442µs
    ├── output rows: 3
    ├── output bytes: 8.00 B
    └── TableScan
        ├── table: default.system.numbers
        ├── output columns: []
        ├── read rows: 3
        ├── read size: < 1 KiB
        ├── partitions total: 1
        ├── partitions scanned: 1
        ├── push downs: [filters: [], limit: NONE]
        ├── estimated rows: 3.00
        ├── cpu time: 87.946µs
        ├── output rows: 3
        └── bytes scanned: 24.00 B

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from zhang2014 August 22, 2024 03:22
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 22, 2024
@sundy-li sundy-li added the ci-cloud Build docker image for cloud test label Aug 22, 2024
Copy link
Contributor

Docker Image for PR

  • tag: pr-16307-b41c7cc-1724309988

note: this image tag is only available for internal use,
please check the internal doc for more details.

@sundy-li sundy-li removed the ci-cloud Build docker image for cloud test label Aug 22, 2024
@sundy-li sundy-li requested a review from b41sh August 22, 2024 12:04
@sundy-li sundy-li added this pull request to the merge queue Aug 22, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Aug 22, 2024
@BohuTANG BohuTANG merged commit 4a6ac70 into databendlabs:main Aug 22, 2024
72 checks passed
@sundy-li sundy-li deleted the udf-retry-count branch August 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants