Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: login and renew return session_token_validity_in_secs too. #16313

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Aug 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

so client can choose to try renew before request, in case some requests is not easy to retry (e.g. upload a a stream as a file).

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 22, 2024
@youngsofun youngsofun added this pull request to the merge queue Aug 28, 2024
Merged via the queue into databendlabs:main with commit 8a61c89 Aug 28, 2024
69 checks passed
@youngsofun youngsofun deleted the session branch August 28, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants