Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix aggregate panic in cluster mode #16319

Merged
merged 14 commits into from
Aug 31, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Aug 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • fix(query): enable spill test
  • fix(query): fix join and aggregate hang in cluster mode
  • fix(query): fix aggregate spill panic in cluster mode
  • fix(query): enable aggregate spill by default

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Aug 23, 2024
@zhang2014 zhang2014 changed the title fix(query): enable spill test fix(query): fix aggregate spill hange Aug 23, 2024
@zhang2014 zhang2014 marked this pull request as ready for review August 31, 2024 02:15
@zhang2014 zhang2014 changed the title fix(query): fix aggregate spill hange fix(query): fix aggregate panic in cluster mode Aug 31, 2024
@BohuTANG BohuTANG merged commit fb38893 into databendlabs:main Aug 31, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants