Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: uri path used as both path and root. #16321

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix: uri path used as both path and root. #16321

merged 2 commits into from
Aug 23, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Aug 23, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

#16304

@Xuanwo is this a mistake or for some reason? It is surprising that this bug didn’t cause any issues before.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun requested a review from Xuanwo August 23, 2024 10:14
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Aug 23, 2024
Xuanwo
Xuanwo approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe it's a bug.

@youngsofun
Copy link
Member Author

@Xuanwo plz review again

@sundy-li sundy-li added this pull request to the merge queue Aug 23, 2024
Merged via the queue into databendlabs:main with commit 0f04b7f Aug 23, 2024
69 checks passed
@rad-pat rad-pat mentioned this pull request Aug 30, 2024
Closed
2 tasks
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youngsofun @Xuanwo @sundy-li