Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vacuum dry run should carry on when target objects are missing #16322

Merged
merged 2 commits into from
Aug 25, 2024
Merged

fix: vacuum dry run should carry on when target objects are missing #16322

merged 2 commits into from
Aug 25, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Aug 23, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

When vacuuming dropped tables in dry-run mode, if the targets being stat do not exist, the vacuum operation should continue rather than quit.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Aug 23, 2024
@dantengsky dantengsky marked this pull request as ready for review August 23, 2024 15:49
@dantengsky dantengsky added this pull request to the merge queue Aug 25, 2024
Merged via the queue into databendlabs:main with commit b5e6155 Aug 25, 2024
72 checks passed
@dantengsky dantengsky deleted the fix-vacuum-dry-run-stat-failure branch August 25, 2024 01:45
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyass zhyass zhyass approved these changes

@SkyFan2002 SkyFan2002 Awaiting requested review from SkyFan2002

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: vacuum dry run should carry on when target objects are missing
2 participants
@dantengsky @zhyass