Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add KVPbApi::get_id_and_value() #16325

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Aug 24, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat: Add KVPbApi::get_id_and_value()

KVPbApi::get_id_and_value() is used to fetch name -> id
and id -> value in one shot.

Add DataId to generalize the id of a value.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • New Feature (non-breaking change which adds functionality)

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 24, 2024
`KVPbApi::get_id_and_value()` is used to fetch `name -> id`
and `id -> value` in one shot.

Add `DataId` to generalize the `id` of a value.
@drmingdrmer drmingdrmer marked this pull request as ready for review August 24, 2024 04:49
@drmingdrmer drmingdrmer merged commit 3fd674a into databendlabs:main Aug 24, 2024
72 checks passed
@drmingdrmer drmingdrmer deleted the 121-tident-error branch August 24, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant