Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce sample possibility to avoid flaky test #16330

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix: reduce sample possibility to avoid flaky test #16330

merged 2 commits into from
Aug 28, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Aug 26, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Aug 26, 2024
@xudong963 xudong963 requested a review from sundy-li August 26, 2024 09:17
@sundy-li sundy-li enabled auto-merge August 28, 2024 03:59
@sundy-li sundy-li added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@BohuTANG BohuTANG merged commit 7a8e6a7 into databendlabs:main Aug 28, 2024
69 checks passed
@xudong963 xudong963 deleted the fix_flaky branch August 28, 2024 07:44
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky test: table_sample.test:94
3 participants
@xudong963 @sundy-li @BohuTANG