-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce an intermediate version that is compatible with vacuum2 #16354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the old version and vacuum2
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Aug 30, 2024
# Conflicts: # src/query/storages/common/table_meta/src/meta/mod.rs # src/query/storages/common/table_meta/src/meta/utils.rs
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Sep 4, 2024
dantengsky
reviewed
Sep 4, 2024
SkyFan2002
force-pushed
the
pre_vacuum2
branch
from
September 5, 2024 03:08
d784fe3
to
b95dfce
Compare
BohuTANG
reviewed
Sep 5, 2024
SkyFan2002
force-pushed
the
pre_vacuum2
branch
from
September 5, 2024 07:09
7abc9c1
to
da8f9ac
Compare
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Sep 5, 2024
dantengsky
previously approved these changes
Sep 5, 2024
dantengsky
approved these changes
Sep 5, 2024
dantengsky
changed the title
feat: introduce an intermediate version that is compatible with both …
feat: introduce an intermediate version that is compatible with vacuum2
Sep 6, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-query
Area: databend query
A-storage
Area: databend storage
lgtm
This PR has been approved by a maintainer
pr-feature
this PR introduces a new feature to the codebase
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
#16049 can be rolled back to this PR, and this PR can be rolled back to older versions. #16049 cannot be directly rolled back to versions before this PR.
v1_main
: 1.2.630-nightly-fb9fc9a680 (Latest version of the main branch at the time of testing)v2_this_pr
: This pull requestv3_vacuum2_pr
: Pull request #16049 (Implementing vacuum2 functionality)Test snapshot_location_from_uuid()
Execute the following statements in
v3_vacuum2_pr
:Change databend query to
v1_main
, and execute:Since
v1_main
is not compatible withv3_vacuum2_pr
, the error is expected, and this indicates that downgrade fromv3_vacuum2_pr
tov1_main
is not applicable, if new data has been written by usingv3_vacuum2_pr
.Change databend query to
v2_this_pr
, and execute:This shows that this PR
v2_this_pr
is compatible withv3_vacuum2_pr
: After upgraded tov3_vacuum2_pr
, and wrote down some new data, it still possible to downgrade tov2_this_pr
.Test block_id_from_location()
Execute the following statements in
v3_vacuum2_pr
:Change databend query to
v1_main
, and execute:Change databend query to
v2_this_pr
, and execute:Tests
Type of change
This change is