Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify SchemaApi::list_indexes(), get_index() list_background_jobs() #16357

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Aug 31, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: simplify SchemaApi::list_indexes(), get_index() list_background_jobs()

Add BaseApi::get_id_value() and BaseApi::list_id_value() to
implement generic get and list for name->id->value meta data.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 31, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review August 31, 2024 12:32
@drmingdrmer drmingdrmer requested review from b41sh and everpcpc August 31, 2024 12:32
…ound_jobs()

Add `BaseApi::get_id_value()` and `BaseApi::list_id_value()` to
implement generic get and list for `name->id->value` meta data.
@drmingdrmer drmingdrmer merged commit 7cf6152 into databendlabs:main Sep 1, 2024
71 checks passed
@drmingdrmer drmingdrmer deleted the 127-list branch September 1, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants