-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: estimate selectivity by table sample #16362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Sep 1, 2024
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Sep 1, 2024
xudong963
force-pushed
the
selectivity_sample
branch
from
September 1, 2024 15:18
a7f68a0
to
94df181
Compare
xudong963
force-pushed
the
selectivity_sample
branch
from
September 4, 2024 06:35
cf1fadd
to
e8d85a4
Compare
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Sep 4, 2024
xudong963
force-pushed
the
selectivity_sample
branch
2 times, most recently
from
September 4, 2024 10:08
ad4112a
to
aec0de4
Compare
xudong963
force-pushed
the
selectivity_sample
branch
from
September 4, 2024 12:11
aec0de4
to
d49a135
Compare
Dousir9
reviewed
Sep 5, 2024
Dousir9
approved these changes
Sep 5, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-planner
Area: planner/optimizer
C-feature
Category: feature
lgtm
This PR has been approved by a maintainer
pr-feature
this PR introduces a new feature to the codebase
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Support estimating filter selectivity by table sample(0.2%).
The dynamic sample may be increased runtime for the query, so to avoid performance downgrading, add a time budget to limit the time, see the setting
dynamic_sample_time_budget_ms
, default is 0 ms.For example, SQL from join order benchmark
Use sample:
For filter,
estimated rows
is similar tooutput rows(real rows)
.No sample
Tests
Type of change
This change is