-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(query): optimize show drop tables #16370
refactor(query): optimize show drop tables #16370
Conversation
16d470c
to
f9c867c
Compare
2bd2ffc
to
14c921d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 20 files at r1, 1 of 19 files at r2, 1 of 13 files at r3, 1 of 4 files at r4, all commit messages.
Reviewable status: 1 of 20 files reviewed, 2 unresolved discussions (waiting on @dantengsky and @TCeason)
src/meta/api/src/schema_api_impl.rs
line 4008 at r5 (raw file):
now: &DateTime<Utc>, tb_id_list: TableIdList, inner_keys: &[String],
use typed key slice such as &[TableId]
instead of String
.
And it looks like tb_id_list
and inner_keys
are duplicated.
src/meta/api/src/schema_api_impl.rs
line 4027 at r5 (raw file):
} tb_metas.push((table_id, tb_meta_seq, tb_meta));
Use SeqV<tb_meta>
to replace tb_meta_seq, tb_meta
so that the caller knows which instance the seq number belongs to.
And return TableId
instead. Avoid using raw u64
whenever a typed Id can be used.
Docker Image for PR
|
ClickBench Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 20 files at r1, 4 of 19 files at r2, 10 of 13 files at r3, 1 of 2 files at r5, 4 of 4 files at r7, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dantengsky and @TCeason)
Docker Image for PR
|
ClickBench Report |
cc @BohuTANG Please review this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @BohuTANG and @dantengsky)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @BohuTANG and @dantengsky)
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Performance
Tests
Type of change
This change is