Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify dictionary API #16371

Merged
merged 2 commits into from
Sep 2, 2024
Merged

refactor: simplify dictionary API #16371

merged 2 commits into from
Sep 2, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 2, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: simplify dictionary API
refactor: simplify update_index() with NameIdValueApi

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 2, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review September 2, 2024 13:55
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 2, 2024
@dosubot dosubot bot added A-meta Area: databend meta serive A-query Area: databend query labels Sep 2, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 2, 2024
@BohuTANG BohuTANG merged commit cec47c8 into databendlabs:main Sep 2, 2024
78 of 79 checks passed
@drmingdrmer drmingdrmer deleted the 133-dict branch September 3, 2024 04:18
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
A-meta Area: databend meta serive A-query Area: databend query lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drmingdrmer @BohuTANG