-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: batch size hint of stream consumption #16372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Sep 2, 2024
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Sep 2, 2024
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
C-feature
Category: feature
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Sep 3, 2024
- add some comments - add extra cases
dantengsky
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @SkyFan2002 PTAL
sundy-li
reviewed
Sep 4, 2024
We should introduce the syntax for the new option |
SkyFan2002
approved these changes
Sep 4, 2024
dantengsky
approved these changes
Sep 4, 2024
@soyeric128 Eric, this new stream option need doc, thanks. |
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-query
Area: databend query
C-feature
Category: feature
lgtm
This PR has been approved by a maintainer
pr-feature
this PR introduces a new feature to the codebase
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Introduces a feature that allows setting a batch size hint for stream consumption. This feature enables the system to optimize how data is read from a stream by providing an upper limit on the batch size, improving efficiency, especially when dealing with large data streams. The change includes updates to the logic for handling stream consumption and adds tests to ensure that the batch size hint works as intended.
Usage
NOTE:
Tests
Type of change
This change is