refactor: Add item count check to KVPbApi::get_pb_stream()
#16377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a `mget()` operation such as `get_pb_stream()` or `get_pb_values()` returns less item than the input keys, it returns an error rather than silently close the stream. This helps the caller to detect early closed stream error.
github-actions
bot
added
the
pr-refactor
…provides mismatch check
drmingdrmer
force-pushed
the
134-kv-pb-api
branch
from
1e6b5e1 to
ca392a4
Compare
dosubot
bot
added
size:L
BohuTANG
approved these changes
Sep 3, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: Add item count check to
KVPbApi::get_pb_stream()If a
mget()operation such asget_pb_stream()orget_pb_values()returns less item than the input keys, it returns an error rather than
silently close the stream. This helps the caller to detect early closed
stream error.
Tests
Type of change
Related Issues
This change is