Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): Simplified sort simple rows implementation #16382

Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore(query): Simplified sort simple rows implementation #16382

merged 1 commit into from
Sep 4, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Sep 3, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Simplified sort simple rows implementation

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Refactoring

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@forsaken628
refine
7b7b557 
Signed-off-by: coldWater <forsaken628@gmail.com>
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 3, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 3, 2024
@dosubot dosubot bot added A-query Area: databend query pr-refactor this PR changes the code base without new features or bugfix labels Sep 3, 2024
@BohuTANG BohuTANG requested a review from sundy-li September 4, 2024 00:19
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 4, 2024
@sundy-li
Copy link
Member

sundy-li commented Sep 4, 2024

@forsaken628 does this pr save memory usage per row ?

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@forsaken628
Copy link
Collaborator Author

@forsaken628 does this pr save memory usage per row ?

should be minimal, SimpleRow has a very short life cycle.

@sundy-li sundy-li added this pull request to the merge queue Sep 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
@forsaken628
chore(query): Simplified sort simple rows implementation (#16382)
1700bdb 
refine

Signed-off-by: coldWater <forsaken628@gmail.com>
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 4, 2024
@BohuTANG BohuTANG merged commit caa1610 into databendlabs:main Sep 4, 2024
102 checks passed
@andylokandy andylokandy mentioned this pull request Oct 15, 2024
Merged
11 tasks
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
@forsaken628 forsaken628 deleted the sort-rows branch October 29, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. pr-refactor this PR changes the code base without new features or bugfix size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forsaken628 @sundy-li @BohuTANG