Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove all share related functions #16383

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 4, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

change: remove all share related functions

The backup of these removed codes is at: https://github.com/datafuselabs/databend/tree/share-bkp
Merge this branch to restore the removed codes.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Other

Related Issues


This change is Reviewable

@drmingdrmer drmingdrmer changed the title change: remove all share related functions refactor: remove all share related functions Sep 4, 2024
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 4, 2024
@drmingdrmer drmingdrmer force-pushed the 137-remove-share branch 4 times, most recently from 15223ee to ca4ea44 Compare September 4, 2024 11:54
@drmingdrmer drmingdrmer marked this pull request as ready for review September 4, 2024 13:37
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 4, 2024
@drmingdrmer
Copy link
Member Author

@TCeason Please have a look at the statement tests changes, make sure no sql statements are removed except SHARE related sqls.
Because some of the statement such as role and share both use grant xxx for privilege management.

@Xuanwo
Copy link
Member

Xuanwo commented Sep 4, 2024

image

@TCeason
Copy link
Collaborator

TCeason commented Sep 4, 2024

@TCeason Please have a look at the statement tests changes, make sure no sql statements are removed except SHARE related sqls.

Because some of the statement such as role and share both use grant xxx for privilege management.

Ok

@TCeason
Copy link
Collaborator

TCeason commented Sep 4, 2024

@TCeason Please have a look at the statement tests changes, make sure no sql statements are removed except SHARE related sqls.

Because some of the statement such as role and share both use grant xxx for privilege management.

This pr not related to user role privilege.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2024
@BohuTANG BohuTANG merged commit f6d9c28 into databendlabs:main Sep 5, 2024
81 checks passed
@BohuTANG
Copy link
Member

BohuTANG commented Sep 5, 2024

@soyeric128 We can remove the SHARE part from the documention now, thanks.

@drmingdrmer drmingdrmer deleted the 137-remove-share branch September 5, 2024 06:59
@drmingdrmer
Copy link
Member Author

The backup of these removed codes is at: https://github.com/datafuselabs/databend/tree/share-bkp
Merge this branch to restore the removed codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants