Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): refactor udf retry #16405

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Sep 5, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query):

  1. external_server_request_retry_times can be zero
  2. don't retry when h2 error occurs
  3. use backon to retry the subblock

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 5, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 5, 2024
Copy link

what-the-diff bot commented Sep 5, 2024

PR Summary

  • Extended Range of 'max_retry_times' Setting
    The range of the 'max_retry_times' setting was previously limited to being between 1 and 1024. With this PR, we've expanded this range to also include 0. This may be beneficial in scenarios where you do not want any retry attempts for some tasks, giving you more control over the system behavior.

@dosubot dosubot bot added the A-query Area: databend query label Sep 5, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 5, 2024
@sundy-li sundy-li requested a review from zhang2014 September 5, 2024 16:35
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 6, 2024
@sundy-li sundy-li changed the title chore(query): external_server_request_retry_times can be zero chore(query): refactor udf retry Sep 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 6, 2024
@BohuTANG BohuTANG merged commit 24e2749 into databendlabs:main Sep 6, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants